imagepbl / effort-sharing

Analysis and plotting scripts for effort sharing, associated with the Carbon Budget Explorer
MIT License
0 stars 0 forks source link

22 figure 4 not running #28

Closed MarkMDekker closed 9 months ago

MarkMDekker commented 9 months ago

Fixes #22

Main changes:

There have been a few very small commits because I had to fiddle with the environments back/forth.

MarkMDekker commented 9 months ago

(I have looked at the conflicts and fixed them). Maybe the self.xr_rbw is not necessary in the allocation class, as it is called already in the AP class, though?

MarkMDekker commented 9 months ago

Ah okay. I will test it myself again and see whether I get the same message. (Maybe something went wrong with shifting around the xr_total in #23

MarkMDekker commented 9 months ago

I pushed a change that should now prevent this permission error. If the rest looks okay from your side, I propose to merge?

chantalwuer commented 9 months ago

I can run it again (and let you know in 30 mins) or merge now, what do you prefer?

MarkMDekker commented 9 months ago

Maybe run it again then, just to be safe. Thanks a lot!