search

imagepbl / effort-sharing

Analysis and plotting scripts for effort sharing, associated with the Carbon Budget Explorer
MIT License
0 stars 0 forks source link

Changes ecpc #29

Closed MarkMDekker closed 9 months ago

MarkMDekker commented 9 months ago

Fixes #25 Fixes #5

Some inconsistencies may remain in plotting scripts. Will look at that iteratively later when improving those scripts, anyway. So for now this PR is for the main core (datareader + allocation classes).

MarkMDekker commented 9 months ago

Hi Chantal, I think I know what is going wrong. I think you did not update the Main.ipynb. Could you try again, by closing that notebook, and re-loading it from the branch? Because the global budgets should be computed after the non-co2 trajectories. The non-co2 trajectories define the xr_traj_nonco2 xarray object, that is later used in the computation of the co2 budgets (after which the global co2 trajectories can be computed). See below for the correct order of running the methods in Main.ipynb: image

MarkMDekker commented 9 months ago

(It seems to run well on my side)

chantalwuer commented 9 months ago

Yes that was the issue, sorry, I didn't realise VS code hadn't updated the branch. All good now!