imageslr / chrome-tab-modifier

Take control of your tabs
https://chrome.google.com/webstore/detail/tab-renamer/kpijejpdbpeaakidlcopnbjohbfimnod
MIT License
10 stars 0 forks source link

right-click menu item not working in windows 10, Chrome/Chromium86 (CentBrowser.com) #5

Closed imageslr closed 3 years ago

imageslr commented 3 years ago

Is only the right-click menu item not working? Or right-click and tray icon both? @dnknn

dnknn commented 3 years ago

Or right-click and tray icon both?

Yes, both . Because these two are exactly the same function

imageslr commented 3 years ago

What's your meaning of not working? Is there no prompt at all when you clicked menu item or right-clicking tray-icon?

I have installed the centbrowser but it works fine for me.

Kapture 2021-02-22 at 23 29 10

dnknn commented 3 years ago

Is there no prompt at all when you clicked menu item or right-clicking tray-icon?

yes!

imageslr commented 3 years ago

Hi, what's your browser version?

Have you try to install this forked extension in a fresh new environment? ---- Update the browser, and sign in a new account or disabled all extensions, then reinstall this extension. I guess it might be conflict with another extension. (just guess :)

dnknn commented 3 years ago

I guess it might be conflict with another extension. (just guess :)

no, I know the reason, But still weird...

Details ![image](https://user-images.githubusercontent.com/10995302/108739348-877f0400-756f-11eb-8a8a-0fc1a27c571a.png)

  1. Install the original author's store version   https://chrome.google.com/webstore/detail/hcbgadmbdkiilgpifjgcakjehmafcjai   🆔 is hcbgadmbdkiilgpifjgcakjehmafcjai

image CentBrowser can directly modify the local files of the extension (i.e. it removes the store verification of the extension)

  1. Clear all files (folders) in the directory above 👆.

  2. download the dist folder of the your repo to Ctrl+V 👆

  3. Bug : right-click menu invalid problem

dnknn commented 3 years ago

Portable version 👇 http://centbrowser.com/history.html

image

imageslr commented 3 years ago

Oh I see. I have tried but I don't why. Replacing an existing extension's file is not a regulary way.

Have you tried to load through "load unpacked file" in developer mode? Is there still the problem?

dnknn commented 3 years ago

Have you tried to load through "load unpacked file" in developer mode? Is there still the problem?

Tested, no problem.

Oh I see. I have tried but I don't why. Replacing an existing extension's file is not a regulary way.

But the problem is: if you don’t do that, it means to give up the https://chrome.google.com/webstore/detail/hcbgadmbdkiilgpifjgcakjehmafcjai version ?

It is estimated that the original author has abandoned the project, or I just use your repo version?

https://download-directory.github.io/?url=https://github.com/imageslr/chrome-tab-modifier/tree/master/dist

What is your opinion?

imageslr commented 3 years ago

Every extension has an unique ID which binds to its source files and runtime states. So simply replacing local files might cause problem due to the inconsistency of the internal state.

Please use my forked version by loading dist directory. They are two different package From Chrome's view. Remember to export your rules first from the origin author's version and then import it in new version.

I will publishing a public package on Chrome web store. It's under review now. I'll let you know!

dnknn commented 3 years ago

I will publishing a public package on Chrome web store. It's under review now. I'll let you know!

💪👍 It’s so pretty, so I don’t have to maintain the version manually !!!

I will wait for your good news!

imageslr commented 3 years ago

I can also make a PR to the origin repo. But that depends on the author to decide accept or not.

dnknn commented 3 years ago

I can also make a PR to the origin repo. But that depends on the author to decide accept or not.

I just install your chrome.google.com/webstore/detail/ version, the original author has given up to continue maintenance.

Title ![image](https://user-images.githubusercontent.com/10995302/108744712-396cff00-7575-11eb-84d8-8f1620c3cb5d.png)
dnknn commented 3 years ago

Hi @imageslr I would like to ask whether it was successfully published in the Chrome web store?

I will publishing a public package on Chrome web store. It's under review now. I'll let you know!

imageslr commented 3 years ago

Hi @dnknn I'm regularly checking it and it's finally public now! Please see Chrome webstore.

dnknn commented 3 years ago

Very great! Thank you very much!!!

dnknn commented 3 years ago

@imageslr https://github.com/imageslr/chrome-tab-modifier You should also add a link to the Chrome webstore on this page so that users can discover it!

imageslr commented 3 years ago

Oh I forgot it. Thanks for you notification!