search

imageworks / Field3D

[NO LONGER MAINTAINED] A library for storing voxel data on disk and in memory.
https://github.com/imageworks/Field3D/wiki/Field3D-Home
BSD 3-Clause "New" or "Revised" License
305 stars 72 forks source link

Field3D 1.4.0 needs library soname bump? #65

Closed hobbes1069 closed 11 years ago

hobbes1069 commented 11 years ago

I just tried building 1.4.0 but the library sonames are still reporting 1.3.2. I did an ABI compliance check and they don't appear to be compatible.

https://dl.dropbox.com/u/34775202/abicompare/Field3D-1.3.2_1.4.0/compat_report.html

hobbes1069 commented 11 years ago

diff -Naur Field3D-1.4.0.orig/CMakeLists.txt Field3D-1.4.0/CMakeLists.txt --- Field3D-1.4.0.orig/CMakeLists.txt 2013-02-04 14:21:23.000000000 -0600 +++ Field3D-1.4.0/CMakeLists.txt 2013-02-06 08:57:57.475064028 -0600 @@ -129,8 +129,8 @@

TARGET_LINK_LIBRARIES ( Field3D ${Field3D_DSO_Libraries} )

-SET_TARGET_PROPERTIES ( Field3D PROPERTIES VERSION 1.3.2) -SET_TARGET_PROPERTIES ( Field3D PROPERTIES SOVERSION 1.3) +SET_TARGET_PROPERTIES ( Field3D PROPERTIES VERSION 1.4.0) +SET_TARGET_PROPERTIES ( Field3D PROPERTIES SOVERSION 1.4)

IF ( CMAKE_HOST_WIN32 ) SET_TARGET_PROPERTIES( Field3D PROPERTIES ENABLE_EXPORTS ON )

magnusw commented 11 years ago

Fixed. Sorry I neglected to update the CMake system, I mainly use SCons myself.

Do you know if it's possible for CMake to parse the .so version from a header file? We keep the version numbers in export/ns.h

hobbes1069 commented 11 years ago

It's definitely possible but not by any builtin feature of cmake that I'm aware of. It would probably take some sort of regex to parse the header. It's not something I've done before but I'll take a stab at it.

magnusw commented 11 years ago

Sounds great. I'll close this ticket for now and make sure to update along with any new tags in the meantime.