Patch for Win32 and add option to build static or shared libs

imageworks / Field3D

[NO LONGER MAINTAINED] A library for storing voxel data on disk and in memory.

https://github.com/imageworks/Field3D/wiki/Field3D-Home

BSD 3-Clause "New" or "Revised" License

305 stars 72 forks source link

Patch for Win32 and add option to build static or shared libs #86

Closed vvnjin closed 8 years ago

vvnjin commented 8 years ago

Patched fnmatch to work on Windows via the Windows API function PathMatchSpec (https://msdn.microsoft.com/en-us/library/windows/desktop/bb773727(v=vs.85).aspx). This fixes issue #84.

Added BUILD_SHARED_LIBS option in CMakeLists.txt to allow users to choose to build static or shared libs, and added FIELD3D_API to a few functions where it is needed for .dll build. This works the same as in OpenEXR's build.

magnusw commented 8 years ago

Thank you for the patch! Much appreciated!

Just one little thing -- we need a CLA filled out before we can take the code. You can find it here: http://opensource.imageworks.com/cla/

Cheers, Magnus

vvnjin commented 8 years ago

Hello! I replied to your email with the CLA as an attachment- Let me know if you didn't receive it and I'll email it again.

magnusw commented 8 years ago

Hi Vivian! Yup - we got the CLA, we're just a bit swamped at the moment. I'll go ahead and merge in the next week or two. Thanks again!