search

imaginary-upside / JellyfinJav

JAV metadata providers for Jellyfin
GNU Affero General Public License v3.0
81 stars 22 forks source link

[Feature Request] Implement A Toggle To Disable Actor/Actress/Star Metadata Pulls #9

Open seniorm0ment opened 3 years ago

seniorm0ment commented 3 years ago

There is currently a "bug" in Jellyfin, where it allows users who do not have access to specific libraries to search for actors/actresses that are attached to videos in libraries that they do not have access to. I assume this was intended design and not a bug, I have brought it up with them but it's been an issue for quite some time and it seems like they need to work-on a partial rewrite of their backend before they can do something like this, not sure. I have suggested the ability to just allow disable searching for specific users all together but it was ignored by them so far, not sure what the current status is on all this tbh.

So for example, if you have adult videos in library2, and you have a user that does not have access to library2, if you go on their account and search for an actress name that is only attached to a video on library2, it shows up in the search. This is of course possibly undesireable on a shared server (there is an argument that a shared server for this content may not be the best idea too, but still..)

It would be nice to have a setting for your addon (toggleable from the jellyfin addon plugin page) that simply disables the plugin from grabbing any actor/actress metadata, and also if a library is forced a full refresh of metadata, it removes any actors/actresses that it originally grabbed in the past. This would be great as a workaround until this can be resolved on jellyfin.

imaginary-upside commented 3 years ago

Honestly most of the actor metadata functionality in Jellyfin is just really broken, so having that happen isn't a surprise.

A toggle on / off switch is easy enough to add. I'll look into if it's possible to easily remove the metadata on a full refresh, if not then I'll just add a manual task.

I wish Jellyfin just the ability to select which actor metadata providers to use, like they do for selecting which video metadata providers to use, but I really doubt anyone will be adding such functionality for a long time. I've thought about adding that into JellyfinJav, but just don't think it's really worth it.

seniorm0ment commented 3 years ago

It works alright for me for the most part, I think they might be doing a rework on the backend or something not sure if that's intended to be improved.

I've been using pheonixadult (jellyfin fork) on jellyfin for nonjav stuff, but it looks like he added some jav support. it might be worth just working with him maybe on that plugin?

Again I haven't used his on my jav library, so I can't say how it works. just a suggestion though, would work as a better all in one nsfw scrape solution rather than have this and that, and less work maintaining for you.