Closed davidheyman closed 1 year ago
@buccalon This is ready for a full review. I'm sure you've seen the translation file here (src/hooks/useLocale.js) which will need fixing by a native speaker. Could you also check to make sure that none of the links have broken? I still need to add a link to switch between the languages but I'll figure out where that goes later.
@davidheyman Thanks for putting this together. Here is what I found:
An unauthenticated user gets 404 at https://narratives-pr-81.onrender.com/en/projects (after clicking in "Login")
The profile picture and 'Manage My Narratives' button for authenticated users disappeared
Sign Up page is not translated: https://narratives-pr-81.onrender.com/pt/signup
Download my data is broken https://narratives-pr-81.onrender.com/download and [locale]/download
Gallery link in the Portuguese Project panel leads to the English gallery (maybe automatic routing in my case)
English-only title placeholder:
English-only password emails:
@buccalon @martimpassos This is now ready for a final look and review. The big change is adding the additional translations around account management.
If we are getting close to your deadline, we can always merge this into master and then handle any outstanding changes there.
I'm getting a "unverified account" error/warning when trying to login in this deployment, same credentials work fine in production
@davidheyman similar issue here. I tried to reset the password, but the action is not completed
@martimpassos It's a different database for the dev version so you'll need to create a new account.
@buccalon According to the database you did successfully reset your password. It's encrypted so I can't see what it is. Can you try again?
@davidheyman I created an account on the dev database. Inputting the correct password gives me You could not be logged in. Please check your username and password.
An incorrect password leads to Your account has not been verified. Please check your email for a verification link.
@davidheyman not working with my original dev account. I had to create another account by typing /signup
in the URL, still, there was something wrong with the form's behavior. I can access the admin dashboard in with my original account on /admin
@davidheyman
These issues should now be resolved and this is ready for another test.
With the account verification, the accounts were being verified a second time on the translation redirect so I've disabled the failure message for double verification.
Thanks, @davidheyman. This is what @martimpassos and I found:
Portuguese version has header menu in English
Geographic layers are English-only and list two empty items
We also felt that the language switch should be consistent across all imagineRio services (either header or footer).
The only critical issue seems to be the English menu, so we agree in merging once it gets fixed.
Locale support and translations