imaginerio / narratives

imagineRio Narratives: a map-based storytelling application
https://narratives.imaginerio.org
0 stars 1 forks source link

Translations #81

Closed davidheyman closed 1 year ago

davidheyman commented 2 years ago

Locale support and translations

davidheyman commented 2 years ago

@buccalon This is ready for a full review. I'm sure you've seen the translation file here (src/hooks/useLocale.js) which will need fixing by a native speaker. Could you also check to make sure that none of the links have broken? I still need to add a link to switch between the languages but I'll figure out where that goes later.

buccalon commented 2 years ago

@davidheyman Thanks for putting this together. Here is what I found:

Issues

Comments

davidheyman commented 2 years ago

@buccalon @martimpassos This is now ready for a final look and review. The big change is adding the additional translations around account management.

If we are getting close to your deadline, we can always merge this into master and then handle any outstanding changes there.

martimpassos commented 2 years ago

I'm getting a "unverified account" error/warning when trying to login in this deployment, same credentials work fine in production

buccalon commented 2 years ago

@davidheyman similar issue here. I tried to reset the password, but the action is not completed

image
davidheyman commented 2 years ago

@martimpassos It's a different database for the dev version so you'll need to create a new account.

davidheyman commented 2 years ago

@buccalon According to the database you did successfully reset your password. It's encrypted so I can't see what it is. Can you try again?

martimpassos commented 2 years ago

@davidheyman I created an account on the dev database. Inputting the correct password gives me You could not be logged in. Please check your username and password. An incorrect password leads to Your account has not been verified. Please check your email for a verification link.

buccalon commented 2 years ago

@davidheyman not working with my original dev account. I had to create another account by typing /signup in the URL, still, there was something wrong with the form's behavior. I can access the admin dashboard in with my original account on /admin

buccalon commented 2 years ago

@davidheyman

davidheyman commented 2 years ago

These issues should now be resolved and this is ready for another test.

With the account verification, the accounts were being verified a second time on the translation redirect so I've disabled the failure message for double verification.

buccalon commented 2 years ago

Thanks, @davidheyman. This is what @martimpassos and I found:

Issues

Suggestions

We also felt that the language switch should be consistent across all imagineRio services (either header or footer).

Comments

The only critical issue seems to be the English menu, so we agree in merging once it gets fixed.