iman-salmani / iplan

Your plan for improving personal life and workflow
GNU General Public License v3.0
128 stars 11 forks source link

App Doesn't Fit On Mobile Devices #44

Open gondolyr opened 1 year ago

gondolyr commented 1 year ago

The app doesn't fit on a Librem 5 without turning on scaling from the phosh-mobile-settings app. The problem with turning on scaling is that the inputs, buttons, and text become small and difficult to read and tap. I expect the app to adapt to the screen like some other GNOME apps like Flatseal and Fragments shown below with the screenshots.

There seems to be a minimum width set for the app that is preventing the app from resizing to 360px wide (the Librem 5's screen width). I think it's defined here in window.ui, though I'm not sure as I'm not familiar with GTK.

Screenshots

IPlan - Scaling Off ![scaling_off](https://github.com/iman-salmani/iplan/assets/57526088/09a7e4f2-bbb5-4cf7-97c3-f4bcae5e8f2b)
IPlan - Scaling On ![scaling_on](https://github.com/iman-salmani/iplan/assets/57526088/fd49a036-66c2-4809-9e2c-3510eb456a6a)
Flatseal Example ![flatseal](https://github.com/iman-salmani/iplan/assets/57526088/9770e933-b903-4ac7-a39b-2340f4f7566f)
Fragments Example ![fragments](https://github.com/iman-salmani/iplan/assets/57526088/49c5bc09-1f9b-4d3b-8556-cf04ec614e82)
iman-salmani commented 1 year ago

Hi @gondolyr thanks for reporting this. Application windows (except for the shortcuts window) are now able to scale down to 360x294. Version 1.7 will be available on Flathub today or tomorrow. I will keep this issue open until the shortcuts window gets fixed. If you experienced any annoying layout or widget feel free to open another issue or continue that here.

gondolyr commented 1 year ago

1.7.0 looks good on the Librem 5 now. Thanks!

Edit: Accidentally forgot about the shortcuts window and closed the issue. I've reopened it.

iplan_1_7_0

gondolyr commented 1 year ago

I've encountered a couple more UI paper cuts on mobile.

Edit: Checkmarks and crosses are as of 1.9.2.

❌ New Project and Edit Project - Icon picker is cut off Edit: 1.9.2: The menu is still cut off, just differently. ![01_new_project_emoji_picker](https://github.com/iman-salmani/iplan/assets/57526088/14c8aac2-3d57-4846-86e7-7252e77137fe) ![11_edit_project_emoji_picker](https://github.com/iman-salmani/iplan/assets/57526088/ce25eb44-f6de-485c-96dc-af8fa4340df9)
❌ Long task name is difficult to press the task itself and not the name A task with a long enough name becomes difficult to enter the task's view and not instead rename the task. ![02_long_name](https://github.com/iman-salmani/iplan/assets/57526088/3e57407f-1472-494d-8178-7a4d3d628c1c) Here I accidentally press on the name and it opens up an input box to rename it. ![03_accidental_rename](https://github.com/iman-salmani/iplan/assets/57526088/e3d00437-4bc0-4273-b886-6885b7bd5ed7) I am trying to open up this view. ![13_open_task](https://github.com/iman-salmani/iplan/assets/57526088/e2d36f8e-aafd-46c0-868f-97d09bc749b0)
✅ Reminders - There's a weird space beween the month and day ![04_weird_space_between_month_and_day](https://github.com/iman-salmani/iplan/assets/57526088/86ec3ebf-d7b0-4fba-8ce7-820c72896b93)
✅ Subtask - Context menus are cut off from the screen ![05_subtask_context_menu_cut_off](https://github.com/iman-salmani/iplan/assets/57526088/39d43221-eade-4eaa-8495-5cb89ec33620) This includes the calendar picker. ![06_calendar_picker_cut_off](https://github.com/iman-salmani/iplan/assets/57526088/673ff6d7-12f0-4f34-9be6-b24a375cedf1) ### The following are context menus that **_do_** fit ##### Headerbar ![08_headerbar_context_menu_fits](https://github.com/iman-salmani/iplan/assets/57526088/82d0a643-f7a6-4c55-a657-d3a90dde0a96) ##### Section There's also a horizontal rule here that isn't present here in the other context menus between "Done tasks" and "Delete section". I don't have a preference to either style currently but having this be consistent with the rest or having the other context menus adjusted to match this style would be preferred. ![09_section_context_menu_fits](https://github.com/iman-salmani/iplan/assets/57526088/b36408e0-f25b-41e0-9bea-80d0c3385b06) ##### Project Task (Not subtask) This is from the main project task list, not a subtask of a task. On another note, this context menu's text is bold while in the other examples I provided, the text is not bolded. ![10_project_task_context_menu_fits](https://github.com/iman-salmani/iplan/assets/57526088/7c7f09a7-2eeb-45ea-a425-02b98e632dfe)
✅ Calendar - App is wider than screen This is from the calendar tab on the left navigation menu. ✅ Note that the headerbar hamburger menu is too close to the right edge of the screen. ![07_calendar_view_too_wide](https://github.com/iman-salmani/iplan/assets/57526088/32bf0b2e-7b45-476f-90dc-eeb9fc2b19a3) ✅ The main body is also too wide and can be scrolled left and right to see more. ![07.1_calendar_leftmost_view](https://github.com/iman-salmani/iplan/assets/57526088/32bf0b2e-7b45-476f-90dc-eeb9fc2b19a3) ![07 2_calendar_rightmost_body_view](https://github.com/iman-salmani/iplan/assets/57526088/638683e9-dfc6-4b62-8848-430224ec2354)
❌ Add task - Inconsistent box/border around button This is present on all views where tasks can be added. When there are no tasks or subtasks added, there is a defined and visible border around the button. Once a single task is added, the border disappears and it's a bit more difficult to know what areas are pressable for it. This is most obvious on the Calendar view shown below. ![08_add_task_inconsistent_border](https://github.com/iman-salmani/iplan/assets/57526088/32bf0b2e-7b45-476f-90dc-eeb9fc2b19a3) Edit (1.8.1): This is fixed for some views but the issue is still present in the list of subtasks.
❌ Sections - No snapping or navigation between sections in horizontal view I would like to have the app center the view on each section when scrolling is necessary but only in horizontal mode. Having a navigation list to jump to each section would be nice too. ![12_sections_horizontal_view_in_between](https://github.com/iman-salmani/iplan/assets/57526088/125f6cac-a688-4a83-9741-2b87252e7f23) Because there's no snapping, it is challenging to perfectly center the view. ![13_sections_cant_center_perfectly_im_human](https://github.com/iman-salmani/iplan/assets/57526088/05aff442-6c1b-4b14-98e1-85fc887a7381)
iman-salmani commented 1 year ago

Thank you. I will work on it.

iman-salmani commented 1 year ago

Hi @gondolyr. It seems popovers only have this positioning issue inside secondary windows. do you experience this in other apps too? if so I think creating an issue about this in Phosh would be helpfull. by the way, I aligned them to the edge of the screen so it should be better now.

gondolyr commented 1 year ago

It seems popovers only have this positioning issue inside secondary windows. do you experience this in other apps too?

Now that you've mentioned it, I checked Fragments and Mousai and noticed the issue there inside secondary windows as well. I'll have to do some digging to see if I should file this upstream with GTK or Phosh.