Code refactoring - Githubissues

imandolatkia / Android-Animated-Theme-Manager

create your custom themes and change them dynamically with ripple animation

Apache License 2.0

703 stars 64 forks source link

Code refactoring #4

Closed wwdablu closed 3 years ago

wwdablu commented 3 years ago

Following are the changes:

companion object was not needed as an instance of ThemeManager can be created from outside
The base activity is lazy creating their own instance of ThemeManager
The base fragment is referring base activity to get hold of the ThemeManager by lazy
Child classes of the activity and fragment can access the ThemeManager by calling getThemeManager()
Kotlin version updated
jcenter() has been replaced with mavenCentral()
versionName and versionCode added to the library
Java 8 support has been added in the gradle

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

imandolatkia commented 3 years ago

Thank you @wwdablu,

It was good refactoring :) But in my local projects, some classes need ThemeManager but don't have access to any fragments or activities. On the other hand, it is not backward compatible. So I added a companion instance for ThemeManager again. Now we have both getThemeManager() and ThemeManager instance.

Thanks for taking the time.

imandolatkia commented 3 years ago

Also, thank you for the other refactors. I merged all of them without any change. @wwdablu