search

imandra-ai / ocaml-opentelemetry

Instrumentation for https://opentelemetry.io
http://docs.imandra.ai/ocaml-opentelemetry/
33 stars 7 forks source link

feat: use runtime metric conventions; add runtime attributes #14

Closed mattjbray closed 2 years ago

mattjbray commented 2 years ago

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/runtime-environment-metrics.md#runtime-environment-specific-metrics---processruntimeenvironment

c-cube commented 2 years ago

I do like it, except I still want to be able to set the service name from within the program :)

mattjbray commented 2 years ago

I do like it, except I still want to be able to set the service name from within the program :)

This PR doesn't change anything about the service name (are you thinking of #12?)