search

imandra-ai / ocaml-opentelemetry

Instrumentation for https://opentelemetry.io
http://docs.imandra.ai/ocaml-opentelemetry/
33 stars 7 forks source link

Use try%lwt over Lwt.catch #31

Closed ELLIOTTCABLE closed 1 year ago

ELLIOTTCABLE commented 1 year ago

The Lwt docs recommend the PPX over the function-call;

Despite the above code, the recommended way to write Lwt.catch is using the try%lwt syntactic sugar from the PPX.

That said, mainly a stylistic difference in this case. Feel free to just close if you're not a fan. (=

c-cube commented 1 year ago

CI seems to be hopelessly broken for now, but it works on linux.