search

imanel / websocket-ruby

Universal Ruby library to handle WebSocket protocol
447 stars 43 forks source link

Support for "Sec-WebSocket-Protocol" header #26

Closed skateman closed 7 years ago

skateman commented 7 years ago

I'd like to use this driver with my socket-to-socket proxy and noVNC. Currently I'm receiving an error about the missing Sec-WebSocket-Protocol header. According to RFC 6455 a server should respond with the same headers, so it should not be a big change. Are you OK with accepting a PR?

imanel commented 7 years ago

Sure, feel free to send PR. Unfortunately I might be tight on time to implement it by myself before end of this week.

I would assume that reason for this bug is that I'm only sending back headers required by spec.

skateman commented 7 years ago

Is it okay if I open 2 PRs, one for the server and one for the client implementations?

imanel commented 7 years ago

No problem with that. I will release new version after they will be merged.

skateman commented 7 years ago

Finally I implemented them together ... looking forward for the new version.

imanel commented 7 years ago

New version released. Thanks a lot for your help!