search

imanghafoori1 / laravel-MasterPass

Helps you securely setup a master password and login into user accounts with it.
MIT License
364 stars 29 forks source link

[bug] doesn’t work with config caching #3

Closed OwenMelbz closed 6 years ago

OwenMelbz commented 6 years ago

Hey :)

Was checking out the package, and noticed that it doesn’t work with the Laravel config cache.

This is because you access the “env” helper directly.

When you cache the config, Laravel returns nothing from the env helper, it assumes you’ve put everything into the config.

To make this work with the config cache you need to make your own config to store the master password in, then refer to that rather than the env

👍🏼

imanghafoori1 commented 6 years ago

Thank for reporting the issue. Could you please check the dev-master version ?

imanghafoori1 commented 6 years ago

fixed as of version 1.1.0 fill free to reopen it if you see that it still exists.