imann24 / now

A chat app with an eye for immediacy
0 stars 0 forks source link

work in progress #15

Open lx93 opened 5 years ago

lx93 commented 5 years ago

Fixes #6

imported react-chat-ui (https://www.npmjs.com/package/react-chat-ui) renamed class {Message} in to {Msg} to avoid naming conflict with react-chat-ui

Problem: right now the chat is always one char behind while chatting with another user. I think it has something to do with react life cycle/state update but couldnt figure out how to resolve.

imann24 commented 5 years ago

Looks like some client-side tests are failing

imann24 commented 5 years ago

Minor bug, seems like there are empty chat bubbles before any message are sent: image

imann24 commented 5 years ago

I think the issue bug you mentioned may have something to do with needing to invoke this.setState whenever a change occurs in the data model

lx93 commented 5 years ago

okay i will try to amend the concerns raised in your comments!

imann24 commented 5 years ago

okay i will try to amend the concerns raised in your comments!

Sounds good! I was just teasing you about the Message to Msg one. Your class name seems more JS-like anyway!

I really like the React messaging UI. Looks very clean