imarc / boilerplate

Responsive CSS, HTML and JavaScript front-end starting point, plus components!
https://imarc-boilerplate.netlify.app/
8 stars 10 forks source link

Update/fontawesome review #26

Closed marcelmoreau closed 4 years ago

marcelmoreau commented 4 years ago

Made some changes which you can review:

khamer commented 4 years ago

This looks good - and it works here - https://deploy-preview-26--imarc-boilerplate.netlify.app/components/detail/messaging.html

I think the only reason I made the mixin different from .fas/.fab/etc. was so that you could use it on an element that contained other stuff (say, on an <li>) and only have those properties affect the pseudo element, whereas <li class="fas fa-check"> Task</li> wouldn't work the way we'd want generally, but maybe no one would do that anyway.

I think it would be worthwhile to make a small .twig to go with _fontawesome.scss to show that it's included and have it show up in the pattern library - it doesn't have to be anything special.