Closed marcelmoreau closed 3 years ago
After those things, it'd hard to tell what new documentation you added to be honest - I can tell you added in some links and formatting, but not sure if there's new content too.
npm run fractal start
makes sense to me because that's the only command with which I could get the project to load in my browser. npm run fractal
does nothing. it's not documented how to fire this up in a browser. if it is, please tell me where.
npm run fractal build
is called in the build script in package.json. if it's unnecessary, why is it there? doesn't one need that to regenerate the build at certain points?
people need to know how to clone and run this. no one does either besides you, tristan, and I and improving this might help foster more involvement.
IMO, it would be helpful if we took 10-15 minutes at the start of tomorrow's FED meeting and had everyone:
then people feel involved, and they would be set up for contributions. we can see where our documentation needs to be improved. otherwise, people are just passively listening.
I did a pass of improvements, trying to expand in the areas you mentioned, in #47 . If we're good with it, I'll merge it in before the meeting later so we can benchmark off the updates.
https://github.com/imarc/boilerplate-components/blob/better-docs/README.md https://github.com/imarc/boilerplate-components/blob/better-docs/.github/CONTRIBUTING.md
sure, merge it in
These edits are to make things more obvious to users – specifically Imarcians. I’ll also call out minor changes as well:
npm run fractal start
,npm run fractal build
) under an explicit View Boilerplate Components locally section in thereadme.md
. I also added the script commands topackage.json
– it did not have themreadme.md
– no more underline dash style