Open marcelmoreau opened 3 years ago
Happy to check out a PR - seems like good stuff to address.
block
for the block and ${block}__${closeButtonElement}
(for example) for a BEM element. Theoretically if we let people custom the a modifier class, I'd think we use something like ${block}__${someElement}--${someModifier}
or ${block__${someElement} -${someModifier}
.
Having issues with this…might create a PR sometime but Tristan would likely need to do last bullet.
#mounted
element needs to exist in markup - can we overwrite this name similarly to how we can overwrite other classes via a prop?<body>
but I am not seeing thatz-index
to this and it appears under other elements on a page that create a new stacking contextfont-size: 0
. this way, if someone actually wanted text for their close button, they couldcloseButtonElement
to me implies that I could specify what DOM element to use (e.g. a<div>
instead of a<button>
) but it's just to control the naming. They all use thisElement
convention but theblock
prop does not