tint-shade: adding sass functions for shades/tints; used them for def…

imarc / boilerplate

Responsive CSS, HTML and JavaScript front-end starting point, plus components!

https://imarc-boilerplate.netlify.app/

8 stars 10 forks source link

tint-shade: adding sass functions for shades/tints; used them for def… #59

Closed marcelmoreau closed 2 years ago

marcelmoreau commented 2 years ago

add shades and tint sass functions
used them in default button hover/focus area

khamer commented 2 years ago

Using sass functions for changing colors (other than opacity) isn't good practice. I tried to avoid it everywhere, but I see there's one place I missed in link.scss that I'll fix.

Beyond that, I know that darken() is the most wrong, but best practice these days would be color.scale() instead of mix().

marcelmoreau commented 2 years ago

alright, yeah I don't know what's involved in that in terms of level 4 Sass stuff. Or if it even needs a PR, or how one might integrate this. Maybe if I look in to this more in the future