imarkoff / Marble-shell-theme

Shell theme for GNOME DE
GNU General Public License v3.0
287 stars 7 forks source link

Gnome dock/dash border #14

Closed in4matix closed 10 months ago

in4matix commented 11 months ago

Hello again!

I did some changes to my setup -- using the default Gnome dock/dash, but it has a dark border: Screenshot from 2023-12-22 20-02-08

And I noticed on your screenshot that no border is present: Screenshot from 2023-12-22 20-22-18

Does your theme control this, and if so, is there a way to remove the border and also to make the opacity darker to match top bar menus?

imarkoff commented 11 months ago

Yes, dash with Marble theme has border:

/* Dash */

#dash .dash-background {
        background-color: DASH-COLOR;
        box-shadow: inset 0 0 0 1px BORDER-MENU-SHADOW;
        padding: 4px 2px 4px 2px;
        border-radius: 21px;
}

box-shadow responds for border color so you can change or remove it in #dash .dash-background selector.

in4matix commented 11 months ago

Pardon my ignorance. This is what it is currently:

/* Dash */

#dash .dash-background {
    background-color: rgba(48, 51, 53, 0.7);
    box-shadow: inset 0 0 0 1px rgba(652, 652, 652, 0.07);
    padding: 4px 2px 4px 2px;
    border-radius: 21px;

Do I need to change the values to what you suggested?

How would I go about changing or removing box-shadow

Just to be clear, I am using Gnome dash that only shows in overview.

in4matix commented 11 months ago

This is a rather crude mockup of what I am trying to achieve: Screenshot from 2023-12-23 08-05-44

in4matix commented 11 months ago

I tried this, but did not make a difference after logging out and back in:

/* Dash */

#dash .dash-background {
    background-color: rgba(48, 51, 53, 0.7);
    box-shadow: inset 0 0 0 0px rgba(0, 0, 0, 0.07);
    padding: 4px 2px 4px 2px;
    border-radius: 21px;
}

Screenshot from 2023-12-23 09-23-42

imarkoff commented 11 months ago

Do I need to change the values to what you suggested?

No, I just gave a part from unbuilt theme.

How would I go about changing or removing box-shadow

You can just remove the line with box-shadow property and reapply the modified theme.

If you are going to change this value, you must follow these rules.

  box-shadow: inset 0 0 0 1px rgba(652, 652, 652, 0.07);

Was this value set by you or was it already there?

imarkoff commented 11 months ago

I tried this, but did not make a difference after logging out and back in:

box-shadow: inset 0 0 0 0px rgba(0, 0, 0, 0.07);

Try to add border: none; or border-color: transparent; property.

imarkoff commented 11 months ago

I tried this, but did not make a difference after logging out and back in:

box-shadow: inset 0 0 0 0px rgba(0, 0, 0, 0.07);

Try to add border: none; or border-color: transparent; property. Maybe that's on Ubuntu side if you are using it.

in4matix commented 11 months ago

Was this value set by you or was it already there?

Yep, they were all already there.

Sorry for nitpicking, but I am a perfectionist ;-)

This did the trick:

/* Dash */

#dash .dash-background {
    background-color: rgba(48, 51, 53, 0.7);
    border: none;
    padding: 4px 2px 4px 2px;
    border-radius: 21px;
}

Screenshot from 2023-12-23 09-59-34

Thank you so much! I love you. Hope you have an awesome festive season.

Ps. I think you can quite safely state that your theme is fully compatible with Gnome 42 also (Ubuntu 22.04.3 LTS)