search

imarkoff / Marble-shell-theme

Shell theme for GNOME DE
GNU General Public License v3.0
261 stars 8 forks source link

Fix issue #38 #39

Closed nikevsoft closed 1 week ago

nikevsoft commented 1 week ago

issue-38

If you don't want this change feel free to delete. It was supposed to be on my own fork, and I can't delete the PR.

imarkoff commented 1 week ago

Wow, thanks for your contribution 🙂. I've already fixed this problem in this commit.

However, GNOME 47 uses a different type of switchers. In new version inside .toggle-switch there is a new component - .handle. So the problem was following: Marble theme adds background-image property to .toggle-switch but GNOME 47 also renders .handle component over it.

There is two solutions that can solve this problem:

  1. Make .handle invisible. New styles will be compatible with older GNOME versions, however in this solution switcher is not animated and it doesn't support accent colors in Settings (yeah it will be also a part of new update).
  2. Don't use switcher as image and stylize .handle. Incompatible with older GNOME versions (script will need to apply styles based on GNOME version), but solves other problems.

Your solution just adjust size of .toggle-switch, so switcher image and .handle has the same size.