search

imatge-upc / activitynet-2016-cvprw

Tools to participate in the ActivityNet Challenge 2016 (NIPSW 2016)
https://imatge-upc.github.io/activitynet-2016-cvprw/
MIT License
195 stars 85 forks source link

[scripts] Potential bug in generate_output during create_stateful_dataset #8

Closed escorciav closed 7 years ago

escorciav commented 7 years ago

Hi guys,

Thank you for sharing your work. It is self-contained and easy to read.

The logic used in the function generate_output is a little bit confusing to me. This line appends the index of the label into output but the else case appends the label into output. I noticed that the output might end up being something like ['none', 2, 2, 'none', 'none']. This input generated an error with the function to_categorical.

Disclaimer: I haven't run the code from scratch. Feel free to close the issue, if you are sure about the logic of the if statement.

albertomontesg commented 7 years ago

Hi @escorciav,

You were right. It seems that writing a refactor of the code after the finish I change the function in a buggy way. It is already fixed it in this commit 32581d432fee500979241cc5ea69159403d66955. I have also shown a demonstration of the correct behavior in this notebook.