search

imath / wp-idea-stream

Share ideas, great ones will rise to the top!
GNU General Public License v2.0
27 stars 5 forks source link

i18n: split sentences / inconsistencies #53

Closed naokomc closed 8 years ago

naokomc commented 8 years ago

We've been translating the plugin in Japanese (we're giving it a spin for WordCamp Tokyo! :tokyo_tower: ) and I found i18n issues with some of the strings.

Split sentences

(In includes/admin/thanks.php#L49)

Thank you for %1$s the latest version of WP Idea Stream! %2$s brings some really cool new features!

Since the word order differs between English and Japanese, we can't translate this split sentence. Please consider spelling out the whole sentence without including placeholders for "activating" and "upgrading to".

The strings below will not be translated correctly in Japanese either (links go to GlotPress strings):

The plugin is called "WP Idea Stream" but I also see several IdeaStream references (GlotPress Search results for IdeaStream). Is this intentional?

Space before colons

There are strings with or without space before colons. To follow the WordPress convention, spaces from these should be removed (GlotPress link):

imath commented 8 years ago

Thanks a lot for your feedback and your contribution to the Japanese translation of the plugin. I'll work on resolving the i18n issues asap.

imath commented 8 years ago

Hi @naokomc

Latest commits above should improve the different parts you mentioned.

I only have one trouble to understand what's wrong with:

Because these are not split sentences.. and i don't see how to improve it for the japanese translation. If you can give me some suggestions i'd be happy to apply them.

naokomc commented 8 years ago

@imath Thank you so much for updating the code to work better for translation. I really appreciate your prompt fixes!

First string

is the default status for all ideas

This is used with a dropdown menu to read for example as "Publish is the default status for all ideas"(Also, did you mean "Published" rather than "Publish" here?). In Japanese, we say "The default status for all ideas is Publish" to mean the same thing. Maybe it's the best if you remove this string and add more description below? Here's what I mean:

ideasteam

I'm also not really sure about what "moderation message one" mean. Is there "message two"?

Second string

the plugin's user profile becomes a new navigation in the BuddyPress member page.

This one is not impossible to translate but it may be better if this whole sentence is combined into one string. I think it's ok to leave this one as is though.

If the setting "Activate BuddyPress integration" is activated and you are using at least version 2.1 of BuddyPress, some nice new functionalities will be available depending on the BuddyPress components you have activated: the plugin's user profile becomes a new navigation in the BuddyPress member page.

imath commented 8 years ago

@naokomc thanks for your suggestion for the first string, i've committed about it.

About the second string, i'd agree if that was the only feature, but it's one out of a list of 4 see https://github.com/imath/wp-idea-stream/blob/2.3.2/includes/buddypress/settings.php#L123

settings-ideastream

So i'll keep it that way.

naokomc commented 8 years ago

Great, all looks good. The second string ("The plugin's user profile...") is capitalized so that makes sense now. Looking forward to the next update.