Move defaults outside $status_data conditional

imath / wp-statuses

WordPress plugin to ease Custom Post Statuses integration

GNU General Public License v2.0

161 stars 27 forks source link

Move defaults outside $status_data conditional #14

Closed JPry closed 5 years ago

JPry commented 7 years ago

Fixes #13.

imath commented 7 years ago

Hi i've tested your PR, i agree it allowes to skip defining the properties you mentioned in #13 But it also makes every WordPress statuses to show inside the metabox dropdown and these statuses shouldn't be listed :

Trash
auto-draft
inherit
Scheduled

So to me it's a no go in this state as it introduces a bug.

JPry commented 7 years ago

Thanks for looking @imath. I'll post some updates with an improved version

ibes commented 5 years ago

that might be closed?