search

imathis / hsl-picker

A most excellent HSL color picker
http://hslpicker.com
MIT License
405 stars 53 forks source link

Dragging the sliders doesn't work #4

Closed nornagon closed 12 years ago

nornagon commented 12 years ago

I'm using Chrome 18.0.1003.1 dev on Mac, and when I click and drag the sliders, nothing happens.

imathis commented 12 years ago

Thanks for the report. I'm not sure about trying to fix things in prerelease versions of Chrome. It could be something buggy with that release and I'd rather not attempt a fix if that's the case. It seems to work fine in the latest stable version of Chrome and any other browser I've tried. If you have some idea what's wrong or can provide a patch that fixes it, I'd really appreciate it.

nornagon commented 12 years ago

If it helps, a brief investigation reveals that the thumbs only have event listeners registered for 'touchstart', not 'mousedown'.

nornagon commented 12 years ago

(Also, Chrome dev usually passes through into stable relatively unchanged. If this is a Chrome bug, you should file a bug at http://new.crbug.com :-) Otherwise it will still be there in stable!)

13k commented 12 years ago

I confirm this bug too. I'm using Chrome 17.0.963.38 beta.

I saw that you were using mootools' Slider, and the demo (which is version 1.4.3) works for me, as you can see

Not sure why it is broken for newer Chromes, maybe it is a mootools bug fixed in newest version.

PS: I know that supporting beta versions is unpractical, but most web developers that I know (and use Chrome) use the beta channel. So perhaps it can be a valid effort to fix reported bugs (so you don't waste time looking/testing ahead) and when the fix is simple enough (like upgrading libs)

13k commented 12 years ago

Upgrading to mootools-core-1.4.3 and mootools-more-1.4.0.1 (with our without compat, full libs or your own build) did not help getting it working... I guess it lands on the "non trivial" bugfix area and we beta Chrome users are doomed by the impossibility of using this awesome tool :(

imathis commented 12 years ago

@13k thanks for giving it a shot. I'll look into it some more when I have time. Sorry for the delay.

kenany commented 12 years ago

Recently started happening to me on 17.0.963.56

kenany commented 12 years ago

Seems fixed now on 17.0.963.83

imathis commented 12 years ago

Thanks @KenanY I actually just noticed that a couple of days ago. Sadly I had just recorded a podcast telling everyone it didn't work on Chrome right now. Oh Google…

13k commented 12 years ago

working for me too now. thanks @imathis