imathis / octopress

Octopress is an obsessively designed framework for Jekyll blogging. It’s easy to configure and easy to deploy. Sweet huh?
http://github.com/imathis/octopress
9.31k stars 2.62k forks source link

Problem with category feeds' code block rendering #1346

Open johnmastro opened 11 years ago

johnmastro commented 11 years ago

I noticed what seems to be a problem with how backtick code block markup is rendered in category feeds. In my main atom.xml everything looks good, but in category feeds the backticks and language name are still present and the code block styling hasn't been performed.

You can take a look by comparing my main feed to my Emacs category feed. The most recent post to appear in both is "Tramping around, part 2"; if you search for "``` common-lisp" you'll see what I mean.

The site is built from the current master branch at the time of writing, though the same thing occurred before I upgraded. You can see the source I'm generating from here, and the source for that particular post here.

I've also noticed the issue on other folks's blogs. Here's another example:

In that feed's case you can find the problem by searching for "``` clojure".

I thought the issue might be related to issue #884 but I rebuilt my site without the markdownify filter on the category feed and didn't appear to have an affect.

feidegenggao commented 11 years ago

how to Unsubscribe ?

2013/9/4 John Mastro notifications@github.com

I noticed what seems to be a problem with how backtick code block markup is rendered in category feeds. In my main atom.xml everything looks good, but in category feeds the backticks and language name are still present and the code block styling hasn't been performed.

You can take a look by comparing my main feed http://jbm.io/atom.xml to my Emacs category feed http://jbm.io/categories/emacs/atom.xml. The most recent post to appear in both is "Tramping around, part 2"; if you search for "``` common-lisp" you'll see what I mean.

The site is built from the current master branch at the time of writing, though the same thing occurred before I upgraded. You can see the source I'm generating from herehttps://github.com/johnmastro/johnmastro.github.com, and the source for that particular post herehttps://github.com/johnmastro/johnmastro.github.com/blob/source/source/_posts/2013-08-20-tramping-around-part-2.markdown .

I've also noticed the issue on other folks's blogs. Here's another example:

  • a category feedhttp://blog.gonzih.me/blog/categories/clojure/atom.xmlwith the issue
  • the corresponding main feed http://blog.gonzih.me/atom.xml without the issue

In that feed's case you can find the problem by searching for "``` clojure".

I thought the issue might be related to issue #884https://github.com/imathis/octopress/issues/884but I rebuilt my site without the markdownify filter on the category feed and didn't appear to have an affect.

¡ª Reply to this email directly or view it on GitHubhttps://github.com/imathis/octopress/issues/1346 .

ÓÐÖ¾Õßʾ¹³É

parkr commented 11 years ago

@feidegenggao go to https://github.com/imathis/octopress and click "unwatch" and the top and make sure you're not watching the repo.

parkr commented 11 years ago

@johnmastro I'm not sure what that's about but it seems like it'd be a pretty simple fix. Markdownify wouldn't cut it as we use the code fence plugin to handle these triple backtick code blocks.

johnmastro commented 11 years ago

@parkr, thanks for the quick reply. I took a look at the plugins (especially backtick_code_block.rb, category_generator.rb, and octopress_filters.rb) but I don't know much Ruby so I didn't get very far.

I stuck a puts in the pre_render method in plugins/octopress_filters.rb and it appeared the only feed that went through was the main /atom.xml, but I'm not sure if that's significant or where to go from there.

Anyway, let me know if there's anything I can do to help with this, I'd love to see it get fixed.

johnmastro commented 10 years ago

Hi @parkr, just wondering if you have any more info on this.

I just updated to master and the problem is still present. I also still see it in the wild pretty often (e.g. here, seach for "```"). It seems especially prevalent on feed aggregators (like the various "planets"), since people often use category or tag feeds with them.

In one reasonably popular RSS client (NewsBlur) it seems to trigger (or at least coincide with) other problems[1], though as far as I can tell that's a bug with NewsBlur itself.

I would be happy to help if I can but I'm not very familiar with the technologies involved.

[1] As in the image below. (Some?) line breaks aren't honored and pre/code is applied inconsistently. As I said, AFAICT this is a bug in NewsBlur rather than Octopress, though in my casual observation they seem to be related somehow (because they often come together).

octopress_code_block_in_newsblur