Closed xuhdev closed 11 years ago
Same problem with latest 2.1
The octopress.js contains some errors. First of all the addCodeLineNumbers() Function does not exists in octopress.js Second the wrapFlashVideos() and flashVideoFallback() Functions do crash. I could fix it on my side by changing all each(i, in each( The i seems to be the problem. As the octopress.addSidebarToggler ist the last called function it isnt call because the functions before crashes. Even the Navigation Menu for mobiles (small Browser Windows) then works again.
And I have put octopress in the require-js.yml dependencies:
@wetty master branch or 2.1?
Its 2.1. On wetty.github.com ist the working version . And it looks like that the master version is working too. There is no variable i in the each Issue #657 is also based on this bug, and work after the fix.
@xuhdev the octopress.js on your site still contains the bugs. Try the octopress.js from my repository https://github.com/wetty/wetty.github.com/tree/source (Sorry, I am still a little unfamiliar with github) Even look at the require-js.yml there. Here are the changes: https://github.com/wetty/wetty.github.com/commit/d8fcecdd0ea6f79c39534f3f38641d0186a91b77
I can't see mobile navigation drop-down on posts / pages where I have embedded video. Could it be related to this same problem? I'm running master branch.
@parkr Do we have any chances to fix this?
I think the latest in the 2.1 branch fixes this.
I just upgraded and these errors show up when I run bundle exec rake generate
.
## Generating Site with Jekyll - ENV: development
rake aborted!
undefined method `collect' for nil:NilClass
/.../lib/octopress/js_asset_manager.rb:18:in `initialize'
/.../Rakefile:114:in `new'
/.../Rakefile:114:in `block in <top (required)>'
/.../Rakefile:155:in `block in <top (required)>'
/Users/xxx/.rvm/gems/ruby-1.9.3-p392/bin/ruby_noexec_wrapper:14:in `eval'
/Users/xxx/.rvm/gems/ruby-1.9.3-p392/bin/ruby_noexec_wrapper:14:in `<main>'
Tasks: TOP => preview
(See full trace by running task with --trace)
Thanks!
Did you just pull from 2.1 or did you run rake update too?
Yes, I pulled from 2.1 and have run rake update
. rake update
works perfectly. I also have run bundle
to update dependencies.
Excellent! You've helped me find a bug. Currently a themes configs aren't being updated when you run rake update. Commit resolution forthcoming.
Thanks, @imathis !
Ok pull again and this time you should just be able to run rake update_configs
and you should be good to go.
@imathis It's fixed. Thanks!
Yep, seems to be working now in 2.1. Any chance to get this fix also into current master branch?
The drop down menu does not show on mobile browsers. I'm using the latest 2.1. My browsers are Safari and Opera Mini on iPhone.