Tagging stable versions

[fnchooft]

Good Evening, Thanks for the great tool. Could we get tags for stable versions?

Fabian

[jschultz]

Glad you like it!

GSL has been largely stable for many years and as far as I am aware any recent activity is largely bugfixes.

Cheers, Jonathan

On 11/10/16 12:27, fnchooft wrote:

Good Evening, Thanks for the great tool. Could we get tags for stable versions?

Fabian

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/imatix/gsl/issues/134, or mute the thread https://github.com/notifications/unsubscribe-auth/AANWzk8o1J4LHeh0Qy35h2ZKHlGHqEvlks5qyuX0gaJpZM4KTJjc.

[fnchooft]

Hi Jonathan, thanks for responding so quickly. I was more thinking about build-systems or dependencies in general. In that case it would be helpful to have a tag instead of a hash to checkout a specific version.

Like for instance in zproject's project.xml: <use project = "zyre" min_major= "1" min_minor = "1" min_patch = "0" />

Currently the version is based on src/version.h - One could use a version.h.in file (automake style) but that would complicate the compilation.

Kind regards,

Fabian

[jschultz]

Sorry I'm afraid I don't know much about this stuff. Since Pieter's death I'm not sure who is in charge here, so maybe you'll just need to fork the project if it's important to have stable releases.

Cheers, Jonathan

On 12/10/16 05:26, fnchooft wrote:

Hi Jonathan, thanks for responding so quickly. I was more thinking about build-systems or dependencies in general. In that case it would be helpful to have a tag instead of a hash to checkout a specific version.

Like for instance in zproject's project.xml: ||

Currently the version is based on src/version.h - One could use a version.sh.in file (automake style) but that would complicate the compilation.

Kind regards,

Fabian

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/imatix/gsl/issues/134#issuecomment-253002445, or mute the thread https://github.com/notifications/unsubscribe-auth/AANWztYFsMF7K_PW7i5Yxz_Zp7EOApk_ks5qy9TWgaJpZM4KTJjc.

[bluca]

There's no need to fork, @evoskuil has admin rights on the repository

[fnchooft]

First of all my condolences, primarily for the family of Pieter. Secondly for the people who had the pleasure of working with him closely. He will be missed and leaves an impressive legacy

[evoskuil]

@bluca, yes - it appears so. Sorry I've been missing notices here, it took me a while to notice this change.

Hi @fnchooft - The version file indicates 4.1c so I went with v4.1.3 (using the zeromq/czmq format).

[bluca]

Thank you! Would be nice if the version header could be changed to match, and to upload a "make dist" tarball to the github release

[evoskuil]

Okay, do you mean this line? I don't know what the "c" implies in 4.1c - I assume it implies a third minor version.

[bluca]

yeah both VERSION and PRODUCT - I think so it was a minor version

[evoskuil]

#define VERSION         "4.1.3"
#define PRODUCT         "GSL/4.1.3"

?

I'm not sure what convention was being followed in PRODUCT, given there was a letter incorporated.

[bluca]

Before it was GSL/4.1b/github: 10a9359cc5b9d00f43abf21bc077460f5021904d So it looks indeed like a minor version. Using 3 digits is simpler IMHO, so what you have there looks good to me

[evoskuil]

All set, tag replaced. I'll try and get to the tarball soon.