imazen / imageflow-dotnet-server

A super-fast image server to speed up your site - deploy as a microservice, serverless, or embeddable.
https://docs.imageflow.io
GNU Affero General Public License v3.0
252 stars 33 forks source link

Imageflow.Net.Server is pinned to ASP.NET Core 2.2 #2

Closed danielcrenna closed 4 years ago

danielcrenna commented 4 years ago

It looks like in order to stay on netstandard2.0, the Imageflow.Net.Server middleware is referencing the legacy AspNetCore packages.

Unfortunately you can only get past this by switching to netcoreapp3.1 (or netcoreapp5.0) and using FrameworkReference.

I was going to issue a PR but want to know the rationale for using netstandard2.0 before I potentially waste time.

lilith commented 4 years ago

We don't need to stay on .NET standard since this is a .NET Core-only project. The Imageflow.Net bindings are .net standard and the helpers should be but the middleware can be changed.

lilith commented 4 years ago

A PR would be great. BTW thank you so much for your support over the years! It matters.