search

imazen / imageflow-dotnet-server

A super-fast image server to speed up your site - deploy as a microservice, serverless, or embeddable.
https://docs.imageflow.io
GNU Affero General Public License v3.0
252 stars 33 forks source link

When should Imageflow.Server require .NET 5.0? #34

Closed lilith closed 3 years ago

lilith commented 3 years ago

Upgrading should be easy, I'm just wondering what end-users would prefer. I don't plan on maintaining two versions.

nza-dk commented 3 years ago

I was actually just looking for a .Net 5.0 version of Imageflow for my own little project 🙂 I can't imagine too many has moved to .Net 5.0 yet, so can't say when it should be a requirement. I think it depends on your feature roadmap. If you have no new features planned, then it would make sense to make the next version for .Net 5.0. Then users on pre-5.0 could use a previous version without loosing any functionality?

lilith commented 3 years ago

I have a few features planned per the other issues, so I guess I'll wait.

Thanks for the feedback!

On Sun, Dec 6, 2020, 7:21 AM Nicki Zabell notifications@github.com wrote:

I was actually just looking for a .Net 5.0 version of Imageflow for my own little project 🙂 I can't imagine too many has moved to .Net 5.0 yet, so can't say when it should be a requirement. I think it depends on your feature roadmap. If you have no new features planned, then it would make sense to make the next version for .Net 5.0. Then users on pre-5.0 could use a previous version without loosing any functionality?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow-dotnet-server/issues/34#issuecomment-739509519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LHZJWQPBNC6IRIKHEELSTOHNZANCNFSM4UPARZOQ .

JayVDZ commented 3 years ago

I think this is premature. Historically, at least in my experience, upgrading framework versions has been simple in theory and complex in practice when faced with any app of maturity.

It might be better to give people notice of intent to stop supporting pre-v5 and wait a year or so before making the jump.

lilith commented 3 years ago

Perhaps I should try to support both via multi-targeting. Are there examples of how that would work re: nuget packaging and the release process?

nza-dk commented 3 years ago

If it's possible, then definitely. I see .NET 5 spreading faster than any previous versions 🙂

lilith commented 3 years ago

It should be possible, I just don't know how terribly messy it will get. And I can't seem to find an example of someone doing this already.

lilith commented 3 years ago

So... it looks like this is a non-issue. I can reference Imageflow.Server from a .NET 5 project as-is, and everything works. Please give it a try and let me know if I overlooked something, but I think this scenario doesn't require multi-targeting since .NET 5 seems to be backwards compatible with asp.net core 3.1

nza-dk commented 3 years ago

I would have thought that it would pollute my publish folder with old .NET framework, but I just tested with a new portable .NET 5 project, and it seems clean and able to run on a server with only .NET 5 installed. It sure is getting easier and easier working with .NET 🙂