search

imazen / imageflow-dotnet-server

A super-fast image server to speed up your site - deploy as a microservice, serverless, or embeddable.
https://docs.imageflow.io
GNU Affero General Public License v3.0
246 stars 33 forks source link

move s3client creation outside imageflow server code #48

Closed edmacdonald closed 2 years ago

lilith commented 3 years ago

I like this. I think we'll have to compensate for the changes and indirection with more documentation but it's certainly doable.

edmacdonald commented 3 years ago

I've added a README that explains how to deal with each breaking change. The required changes are minimal, and with one exception, will make themselves known at compile time. The only change that I think might potentially be tricky is the parameterless constructor for S3ServiceOptions() no longer uses the AnonymousAWSCredentials.

edmacdonald commented 3 years ago

@lilith is there anything else you would like to see in this?

lilith commented 3 years ago

I will probably roll this into a later breaking release that includes other changes. Thank you so much for your work on this!

On Thu, Apr 8, 2021, 5:52 AM Ed MacDonald @.***> wrote:

@lilith https://github.com/lilith is there anything else you would like to see in this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow-dotnet-server/pull/48#issuecomment-815707303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LH37FEEBLGIII4WMPV3THWKIPANCNFSM42AU6RUA .

edmacdonald commented 2 years ago

@lilith any chance you would consider publishing a beta or alpha of the Imageflow.Server.Storage.S3 package with these changes? I've been using this in production without issue since opening this PR.