search

imazen / imageflow-dotnet-server

A super-fast image server to speed up your site - deploy as a microservice, serverless, or embeddable.
https://docs.imageflow.io
GNU Affero General Public License v3.0
246 stars 33 forks source link

Wish: Migrate to System.Text.Json instead of newtonsoft #82

Open iJungleboy opened 1 year ago

iJungleboy commented 1 year ago

ATM it appears that Newtonsoft is still being used, but I think only in the watermark (but I'm not sure).

Since we like keeping our third-party dependencies as clean as possible, I would like to ask to migrate to System.Text.Json instead. I believe it's a very small change.

@tvatavuk fyi

lilith commented 1 year ago

It's used for all JSON serialization in the Imageflow .NET wrapper, so migrating that library first would make sense. I think I opened an issue for thar goal, but haven't had time yet.

On Mon, Jul 3, 2023, 11:50 PM iJungleboy @.***> wrote:

ATM it appears that Newtonsoft is still being used, but I think only in the watermark (but I'm not sure).

Since we like keeping our third-party dependencies as clean as possible, I would like to ask to migrate to System.Text.Json instead. I believe it's a very small change.

@tvatavuk https://github.com/tvatavuk fyi

— Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow-dotnet-server/issues/82, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LHZARARKUNAXJKP7MLLXOLL2HANCNFSM6AAAAAAZ4SDEUU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

iJungleboy commented 1 year ago

@lilith no problem, been there all the time 😉. Thanks for everything.

lilith commented 1 year ago

It's definitely something I want to have changed, but probably more integration tests would be needed.

On Tue, Jul 4, 2023, 3:31 PM iJungleboy @.***> wrote:

@lilith https://github.com/lilith no problem, been there all the time 😉. Thanks for everything.

— Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow-dotnet-server/issues/82#issuecomment-1619583019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LH7G4TQ7IDXD6KHORMDXOO2DPANCNFSM6AAAAAAZ4SDEUU . You are receiving this because you were mentioned.Message ID: @.***>