imazen / imageflow

High-performance image manipulation for web servers. Includes imageflow_server, imageflow_tool, and libimageflow
https://docs.imageflow.io/
GNU Affero General Public License v3.0
4.14k stars 140 forks source link

[QUESTION] Why is rustc_serialize being used? #569

Closed Absolucy closed 3 years ago

Absolucy commented 3 years ago

I was attempting to compile this, and ran into errors relating to rustc_serialize

Upon further investigation, I found that rustc_serialize has been considered deprecated for years (since April 2017, to be exact), and I'm curious, why is this still being used?

lilith commented 3 years ago

Thank you for reporting this.

It was used for base64 and hexadecimal encoding. I've just pushed an update to main that replaces it with the base64 and hex crates. Imageflow was started in 2014, so we do use a few older crates.

lilith commented 3 years ago

Also, apologies for the unpolished Rust interface. This library is primarily used by non-rust (C#, Node, Elixir, Golang, etc) clients, so my focus has gone into those bindings and corresponding servers. If you can share more about your usage scenario I can probably help give you a cleaner API.