Closed anshulrgoyal closed 3 years ago
Does windows already have NASM? No, NASM install is failing soi disabled it for time bieng
Spelling allowlist needs to be updated. Also, changes need to be rebased then squashed.
For some reason, only some packages seem to be updating in GitHub: https://github.com/anshulrgoyal?tab=packages&repo_name=imageflow - The latest version for some is rc93, for others rc100 or rc101
We need to show that a release can update them all correctly.
Spelling allowlist needs to be updated. Also, changes need to be rebased then squashed.
For some reason, only some packages seem to be updating in GitHub: https://github.com/anshulrgoyal?tab=packages&repo_name=imageflow - The latest version for some is rc93, for others rc100 or rc101
We need to show that a release can update them all correctly.
Because earlier we had 18 packages now we have just 10 so rest 8 aren't updated
I thought I sent you my links for 32 and 64 bit nasm
On Thu, Dec 24, 2020, 12:21 AM Anshul Goyal notifications@github.com wrote:
@anshulrgoyal commented on this pull request.
In .github/workflows/test_ci.yml https://github.com/imazen/imageflow/pull/570#discussion_r548426757:
- shell: bash
- env:
- RUSTFLAGS: -C target-cpu=${{matrix.TARGET_CPU}}
- test_win32:
- runs-on: windows-2019
- steps:
- name: Checkout code
- uses: actions/checkout@master
Install Nasm with fallback to S3
- name: Install nasm
- run: choco install nasm
- name: Install nasm
- run: |
- curl -L -o nasminst.exe https://argoyal.s3.us-east-2.amazonaws.com/nasm-2.14.02-installer-x64.exe
It was just for testing when u integrate u need to add those links
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow/pull/570#discussion_r548426757, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LH5J2MYO4HM22HXSHWDSWLTYHANCNFSM4UREZLZQ .
Look closer at the package versions. The native tool packages haven't been updated as recently, even the ones we kept.
On Thu, Dec 24, 2020, 12:10 AM Anshul Goyal notifications@github.com wrote:
Spelling allowlist needs to be updated. Also, changes need to be rebased then squashed.
For some reason, only some packages seem to be updating in GitHub: https://github.com/anshulrgoyal?tab=packages&repo_name=imageflow - The latest version for some is rc93, for others rc100 or rc101
We need to show that a release can update them all correctly.
Because earlier we had 18 packages now we have just 10 so rest 8 aren't updated
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow/pull/570#issuecomment-750781512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LHZYK5QUAYTY6I5ZDL3SWLSNZANCNFSM4UREZLZQ .
Look closer at the package versions. The native tool packages haven't been updated as recently, even the ones we kept. … On Thu, Dec 24, 2020, 12:10 AM Anshul Goyal @.***> wrote: Spelling allowlist needs to be updated. Also, changes need to be rebased then squashed. For some reason, only some packages seem to be updating in GitHub: https://github.com/anshulrgoyal?tab=packages&repo_name=imageflow - The latest version for some is rc93, for others rc100 or rc101 We need to show that a release can update them all correctly. Because earlier we had 18 packages now we have just 10 so rest 8 aren't updated — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#570 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LHZYK5QUAYTY6I5ZDL3SWLSNZANCNFSM4UREZLZQ .
It is fixed it was due to wrong repo
The actions can compile code, test, and deploy for multiple platforms.
Required ENV: