search

imazen / imageflow

High-performance image manipulation for web servers. Includes imageflow_server, imageflow_tool, and libimageflow
https://docs.imageflow.io/
GNU Affero General Public License v3.0
4.14k stars 140 forks source link

Passing a file path to the image flow context #571

Closed Amraneze closed 3 years ago

Amraneze commented 3 years ago

Hi @lilith,

I just have a question if imageflow can also accept file path instead of a buffer ? And also we are working on implementing a binding to imageflow with Scala/Java (imageflow-scala)[https://github.com/Dealermade/imageflow-scala]

Thanks!

lilith commented 3 years ago

I would recommend reading a file into a buffer then passing that to imageflow. We don't expose a file path API (among other reasons) because character sets can differ and because it wouldn't speed anything up.

Letting the binding language handle File IO also allows for async support.

Thank you so much for working on bindings for java/scala. Let me know if you have any questions and I will try to help.

On Sat, Dec 12, 2020, 3:20 PM Amrane Ait Zeouay notifications@github.com wrote:

Hi @lilith https://github.com/lilith,

I just have a question if imageflow can also accept file path instead of a buffer ? And also we are working on implementing a binding to imageflow with Scala/Java (imageflow-scala)[ https://github.com/Dealermade/imageflow-scala]

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow/issues/571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LH3ZZ2KBS5TTEC2WCY3SUPUELANCNFSM4UYW7K4A .

lilith commented 3 years ago

Also, https://github.com/imazen/imageflow-dotnet is our set of reference bindings and is a good design to copy. The ImageJob API makes usage easy even if you need a complex graph of operations.

On Sat, Dec 12, 2020, 3:29 PM Lilith River lilith@imazen.io wrote:

I would recommend reading a file into a buffer then passing that to imageflow. We don't expose a file path API (among other reasons) because character sets can differ and because it wouldn't speed anything up.

Letting the binding language handle File IO also allows for async support.

Thank you so much for working on bindings for java/scala. Let me know if you have any questions and I will try to help.

On Sat, Dec 12, 2020, 3:20 PM Amrane Ait Zeouay notifications@github.com wrote:

Hi @lilith https://github.com/lilith,

I just have a question if imageflow can also accept file path instead of a buffer ? And also we are working on implementing a binding to imageflow with Scala/Java (imageflow-scala)[ https://github.com/Dealermade/imageflow-scala]

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/imazen/imageflow/issues/571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA2LH3ZZ2KBS5TTEC2WCY3SUPUELANCNFSM4UYW7K4A .

Amraneze commented 3 years ago

Thank you @lilith for your replies.