0.0.17 is a bit stricter, previous versions tolerated stems, e.g. docker+ed. Unfortunately, that resulted in it accepting misspellings. This will mean a slightly longer list of items, but since the tool should generate the updates automatically, this shouldn't be a big deal. In my experience, it's a tiny fraction of items in the list.
In this PR, I'm also changing the name of the expect file (this has been supported since 0.0.16). The previous term is no longer considered best practice. I don't have a timeline for when I'd actually drop support for it, but...
With this version, you no longer need the schedule event -- pull_request_target manages things. This means that PRs will see ✅ or ❌ from the action. -- You can see this in action in https://github.com/check-spelling/imageflow/pull/1 (you can test by making a PR to this repository, or to your own).
I'm hoping the next version will enable the bot to automatically update files. But I'm going to need to pay careful attention to the line ending case.
lilith
commented
3 years ago
0.0.17 is a bit stricter, previous versions tolerated stems, e.g.
docker+ed. Unfortunately, that resulted in it accepting misspellings. This will mean a slightly longer list of items, but since the tool should generate the updates automatically, this shouldn't be a big deal. In my experience, it's a tiny fraction of items in the list.In this PR, I'm also changing the name of the expect file (this has been supported since 0.0.16). The previous term is no longer considered best practice. I don't have a timeline for when I'd actually drop support for it, but...
With this version, you no longer need the
scheduleevent --pull_request_targetmanages things. This means that PRs will see ✅ or ❌ from the action. -- You can see this in action in https://github.com/check-spelling/imageflow/pull/1 (you can test by making a PR to this repository, or to your own).I'm hoping the next version will enable the bot to automatically update files. But I'm going to need to pay careful attention to the line ending case.