Flake8 issues

[marksutherland]

You possibly don't care about this, but for the record here is the output from pipenv check --style .:

safeyaml.py:10:1: W293 blank line contains whitespace
safeyaml.py:12:1: W293 blank line contains whitespace
safeyaml.py:14:1: E402 module level import not at top of file
safeyaml.py:14:1: F811 redefinition of unused 'sys' from line 5
safeyaml.py:21:80: E501 line too long (113 > 79 characters)
safeyaml.py:23:80: E501 line too long (113 > 79 characters)
safeyaml.py:26:80: E501 line too long (86 > 79 characters)
safeyaml.py:28:80: E501 line too long (102 > 79 characters)
safeyaml.py:46:32: E261 at least two spaces before inline comment
safeyaml.py:47:1: E302 expected 2 blank lines, found 0
safeyaml.py:52:22: E703 statement ends with a semicolon
safeyaml.py:58:1: E302 expected 2 blank lines, found 1
safeyaml.py:59:80: E501 line too long (125 > 79 characters)
safeyaml.py:66:1: E302 expected 2 blank lines, found 1
safeyaml.py:69:5: E301 expected 1 blank line, found 0
safeyaml.py:89:1: E302 expected 2 blank lines, found 1
safeyaml.py:92:1: E302 expected 2 blank lines, found 1
safeyaml.py:99:1: E302 expected 2 blank lines, found 1
safeyaml.py:102:1: E302 expected 2 blank lines, found 1
safeyaml.py:105:1: E302 expected 2 blank lines, found 1
safeyaml.py:108:1: E302 expected 2 blank lines, found 1
safeyaml.py:111:1: E302 expected 2 blank lines, found 1
safeyaml.py:114:1: E302 expected 2 blank lines, found 1
safeyaml.py:117:1: E302 expected 2 blank lines, found 1
safeyaml.py:120:1: E302 expected 2 blank lines, found 1
safeyaml.py:123:1: E302 expected 2 blank lines, found 1
safeyaml.py:126:1: E302 expected 2 blank lines, found 1
safeyaml.py:156:1: E302 expected 2 blank lines, found 1
safeyaml.py:163:19: E225 missing whitespace around operator
safeyaml.py:165:19: E225 missing whitespace around operator
safeyaml.py:171:23: E225 missing whitespace around operator
safeyaml.py:175:26: W291 trailing whitespace
safeyaml.py:180:1: E302 expected 2 blank lines, found 1
safeyaml.py:198:80: E501 line too long (105 > 79 characters)
safeyaml.py:204:80: E501 line too long (190 > 79 characters)
safeyaml.py:207:80: E501 line too long (117 > 79 characters)
safeyaml.py:208:1: W293 blank line contains whitespace
safeyaml.py:215:80: E501 line too long (80 > 79 characters)
safeyaml.py:224:80: E501 line too long (112 > 79 characters)
safeyaml.py:226:80: E501 line too long (126 > 79 characters)
safeyaml.py:228:80: E501 line too long (83 > 79 characters)
safeyaml.py:237:15: E225 missing whitespace around operator
safeyaml.py:238:38: E231 missing whitespace after ','
safeyaml.py:239:80: E501 line too long (145 > 79 characters)
safeyaml.py:243:80: E501 line too long (107 > 79 characters)
safeyaml.py:249:80: E501 line too long (83 > 79 characters)
safeyaml.py:259:1: W293 blank line contains whitespace
safeyaml.py:262:1: E302 expected 2 blank lines, found 1
safeyaml.py:272:35: E231 missing whitespace after ','
safeyaml.py:272:80: E501 line too long (109 > 79 characters)
safeyaml.py:276:80: E501 line too long (114 > 79 characters)
safeyaml.py:278:80: E501 line too long (219 > 79 characters)
safeyaml.py:281:15: E225 missing whitespace around operator
safeyaml.py:282:38: E231 missing whitespace after ','
safeyaml.py:286:80: E501 line too long (135 > 79 characters)
safeyaml.py:286:118: E231 missing whitespace after ','
safeyaml.py:289:1: W293 blank line contains whitespace
safeyaml.py:295:80: E501 line too long (132 > 79 characters)
safeyaml.py:302:30: E701 multiple statements on one line (colon)
safeyaml.py:303:80: E501 line too long (98 > 79 characters)
safeyaml.py:314:1: W293 blank line contains whitespace
safeyaml.py:324:80: E501 line too long (190 > 79 characters)
safeyaml.py:327:80: E501 line too long (117 > 79 characters)
safeyaml.py:328:1: W293 blank line contains whitespace
safeyaml.py:330:5: E303 too many blank lines (2)
safeyaml.py:354:1: W293 blank line contains whitespace
safeyaml.py:358:35: E231 missing whitespace after ','
safeyaml.py:358:80: E501 line too long (81 > 79 characters)
safeyaml.py:364:9: E266 too many leading '#' for block comment
safeyaml.py:370:26: E201 whitespace after '('
safeyaml.py:370:80: E501 line too long (117 > 79 characters)
safeyaml.py:372:50: E231 missing whitespace after ','
safeyaml.py:376:80: E501 line too long (134 > 79 characters)
safeyaml.py:376:117: E231 missing whitespace after ','
safeyaml.py:395:80: E501 line too long (103 > 79 characters)
safeyaml.py:395:91: E231 missing whitespace after ','
safeyaml.py:398:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
safeyaml.py:403:1: E302 expected 2 blank lines, found 1
safeyaml.py:413:38: E231 missing whitespace after ','
safeyaml.py:413:80: E501 line too long (112 > 79 characters)
safeyaml.py:418:43: E231 missing whitespace after ','
safeyaml.py:418:80: E501 line too long (151 > 79 characters)
safeyaml.py:429:1: E302 expected 2 blank lines, found 1
safeyaml.py:452:29: E201 whitespace after '('
safeyaml.py:452:80: E501 line too long (112 > 79 characters)
safeyaml.py:454:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
safeyaml.py:461:1: E302 expected 2 blank lines, found 1
safeyaml.py:522:1: E302 expected 2 blank lines, found 1
safeyaml.py:558:80: E501 line too long (86 > 79 characters)
safeyaml.py:564:1: E302 expected 2 blank lines, found 1
safeyaml.py:579:39: E231 missing whitespace after ','
safeyaml.py:579:80: E501 line too long (182 > 79 characters)
safeyaml.py:581:80: E501 line too long (128 > 79 characters)
safeyaml.py:590:80: E501 line too long (171 > 79 characters)
safeyaml.py:595:80: E501 line too long (113 > 79 characters)
safeyaml.py:599:80: E501 line too long (123 > 79 characters)
safeyaml.py:601:80: E501 line too long (111 > 79 characters)
safeyaml.py:602:80: E501 line too long (104 > 79 characters)
safeyaml.py:603:80: E501 line too long (153 > 79 characters)
safeyaml.py:604:80: E501 line too long (131 > 79 characters)
safeyaml.py:605:80: E501 line too long (126 > 79 characters)
safeyaml.py:606:80: E501 line too long (112 > 79 characters)
safeyaml.py:607:80: E501 line too long (102 > 79 characters)
safeyaml.py:608:80: E501 line too long (103 > 79 characters)
safeyaml.py:609:80: E501 line too long (91 > 79 characters)
safeyaml.py:611:80: E501 line too long (105 > 79 characters)
safeyaml.py:613:31: E261 at least two spaces before inline comment
safeyaml.py:614:1: W293 blank line contains whitespace
safeyaml.py:641:80: E501 line too long (98 > 79 characters)
safeyaml.py:654:80: E501 line too long (97 > 79 characters)
safeyaml.py:658:42: E261 at least two spaces before inline comment
safeyaml.py:666:80: E501 line too long (90 > 79 characters)
safeyaml.py:677:1: W391 blank line at end of file
tests.py:14:36: E231 missing whitespace after ':'
tests.py:15:33: E231 missing whitespace after ':'
tests.py:16:31: E231 missing whitespace after ','
tests.py:16:33: E231 missing whitespace after ','
tests.py:17:31: E231 missing whitespace after ','
tests.py:17:33: E231 missing whitespace after ','
tests.py:18:33: E231 missing whitespace after ':'
tests.py:19:33: E231 missing whitespace after ':'
tests.py:73:13: E722 do not use bare except'

[aanand]

I care! We should get that check into tox.ini, and also set up Travis (or whatever's cool now) to run tests and whatever code quality metrics we want.

[aanand]

(is Tox still cool or are we using something else now???)

[marksutherland]

I'm not yet aware of anything cooler than tox. I can update the pipenv PR to include this with a - to disable the failure until these are cleaned up.

[aanand]

👍