search

imballinst / react-bs-datatable

Bootstrap datatable without jQuery. Features include: filter, sort, pagination, checkbox, and control customization.
https://imballinst.github.io/react-bs-datatable
MIT License
60 stars 20 forks source link

custom_cell_representation #10

Closed rockwelln closed 6 years ago

rockwelln commented 6 years ago

and the custom cell representation seems very interesting (at least for me).

imballinst commented 6 years ago

I was a bit skeptical about this, but when I thought about it again earlier this morning, true, sometimes we want to left the raw data unmodified. I think this is a really good feature. Great job!

Anyway, what do you think should I do with the old feature (tableBody can handle React Components and such)? Should I keep it? Personally, I would like to keep it for the time being; so the user can choose based on their needs.

rockwelln commented 6 years ago

Thank you. 100% agree with you, the user may be able to choose. So the « old » feature should remain.

imballinst commented 6 years ago

Alright, I will merge this soon, probably tonight/tomorrow :+1:

imballinst commented 6 years ago

This PR has been merged along with #9. Thanks @NormanDenayer!