imballinst / react-bs-datatable

Bootstrap datatable without jQuery. Features include: filter, sort, pagination, checkbox, and control customization.
https://imballinst.github.io/react-bs-datatable
MIT License
60 stars 20 forks source link

Allow search against null values #141

Closed shawnwall closed 2 years ago

shawnwall commented 2 years ago

Let me know if there's anything else I can provide or help with here

Fixes https://github.com/imballinst/react-bs-datatable/issues/140

imballinst commented 2 years ago

hey @shawnwall, thanks for creating the issue and for contributing with this PR! I really appreciate it.

Could you help update this part? It seems this part of the code causes the build to fail:

[build:*docs] Error: src/stories/00-Uncontrolled.stories.tsx:168:25 - error TS2322: Type '({ name: string; username: string; date: string; score: number; location: string; status: string; } | { name: string; username: string; date: string; score: number; location: null; status: string; })[]' is not assignable to type 'StoryColumnType[]'.

Perhaps the update is just changing the location from string to string | null and then we should be good to merge this. Thanks!

shawnwall commented 2 years ago

updated with your suggestion, and a local yarn build ran successfully.