imballinst / react-bs-datatable

Bootstrap datatable without jQuery. Features include: filter, sort, pagination, checkbox, and control customization.
https://imballinst.github.io/react-bs-datatable
MIT License
60 stars 20 forks source link

Node 17+ #166

Closed ewelina-zielinska closed 1 year ago

ewelina-zielinska commented 1 year ago

Would it be possible to stop demanding the node 16 engine and enable newer ones?

Great work, thank you for creating this lib.

imballinst commented 1 year ago

hi @ewelina-zielinska, that'll be absolutely possible and I think is a great point. Thanks for the feedback! I'll try to work on it tonight.

imballinst commented 1 year ago

hi @ewelina-zielinska, I have published 3.8.1: https://www.npmjs.com/package/react-bs-datatable/v/3.8.1.

I have tested it as well on my end when developing it with Node 18. Before:

@imballinst ➜ /workspaces/react-bs-datatable (allow-node-above-16) $ yarn
yarn install v1.22.19
[1/5] Validating package.json...
error react-bs-datatable@3.8.0: The engine "node" is incompatible with this module. Expected version "16". Got "18.15.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

After:

@imballinst ➜ /workspaces/react-bs-datatable (allow-node-above-16) $ yarn
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > babel-loader@8.2.3" has unmet peer dependency "webpack@>=2".
warning "@storybook/addon-essentials > @storybook/addon-docs > @storybook/core > @storybook/core-client@6.4.14" has unmet peer dependency "webpack@*".
warning " > @storybook/testing-react@1.2.3" has unmet peer dependency "@storybook/addons@>=6.4.0".
warning " > @storybook/testing-react@1.2.3" has unmet peer dependency "@storybook/client-api@>=6.4.0".
warning " > @storybook/testing-react@1.2.3" has unmet peer dependency "@storybook/preview-web@>=6.4.0".
warning " > bootstrap@5.1.3" has unmet peer dependency "@popperjs/core@^2.10.2".
warning Workspaces can only be enabled in private projects.
[5/5] Building fresh packages...

Could you check on your end and see if it it's been resolved? Thanks!

ewelina-zielinska commented 1 year ago

Looks good! Thank you :)