Cannot re-render?

[ans-4175]

Looking through https://imballinst.github.io/react-bs-datatable/ I put search text and changed number show options per page. But it won't rendered, any misconfig on your gh-pages ?

[imballinst]

Hi there!

I'm sorry I couldn't reproduce your problem with Chrome 55.0.2 and Firefox 50.1. I think, if the table doesn't render any row, your search text doesn't find any matching column in the given dataset. Could you give the steps to reproduce it and if possible, the screenshot as well, so I can analyze it further? Thanks

[ans-4175]

Changed to third page

Then search brandy, nothing result.

Looks like searching only works in first page?

[imballinst]

You're right, there's a pagination problem when filtering on the pages other than the first one. My guess is that when the user filters the data, the "current pagination before filter" persists.

1. User A switches to page 3 (page state on the table set to 3)
2. User A enters a text to the input field
3. This causes the entire dataset to be filtered based on A's input. Therefore, the table that once has N pages will now have less than N pages
4. If N <= 3, the component is still working. However, if N < 3, it will cause rendering problem because the component's state tells the render method to render the 3rd page, which is undefined after the filter.

Thanks for your report, I will address this issue soon.

[imballinst]

@ans-4175 Hi, I just pushed a commit that should fix this issue. Please check the Github Page of this repo to see whether this issue has been resolved or not

[ans-4175]

Still has a bug. If I put text to search, then only produced one result. I still can click next page button, so it will show empty results. Shouldn't be disabled the pagination button?

[imballinst]

My bad, missed a logic on empty-dataset pagination. How is it now?

[ans-4175]

Good, works perfectly :)