search

imballinst / react-bs-datatable

Bootstrap datatable without jQuery. Features include: filter, sort, pagination, checkbox, and control customization.
https://imballinst.github.io/react-bs-datatable
MIT License
60 stars 20 forks source link

Fix async functions #78

Closed KapitanOczywisty closed 3 years ago

KapitanOczywisty commented 3 years ago

I think these functions should return void

https://github.com/Imballinst/react-bs-datatable/blob/4c6f34861aa708fc39ef616071ee3dae6404412f/README.md#L205-L208

KapitanOczywisty commented 3 years ago

@Imballinst just remember to update lib ;)

Edit: I don't see any testing in this library, those stuff could be found easily with that. Not to mention pull request validation with github actions.

imballinst commented 3 years ago

iuhh, yes, that's a good idea. Previously I had this Travis CI—but since its migration, the build fails and hence I disabled it. Tracking it in https://github.com/Imballinst/react-bs-datatable/issues/81.