search

imballinst / react-bs-datatable

Bootstrap datatable without jQuery. Features include: filter, sort, pagination, checkbox, and control customization.
https://imballinst.github.io/react-bs-datatable
MIT License
59 stars 20 forks source link

Minor Fix #98

Closed ahmetunal closed 2 years ago

ahmetunal commented 2 years ago

The error:

If you want to write it to the DOM, pass a string instead: inline="true" or inline={value.toString()}. at form at https://localhost:8500/dist/js/bundle.js:86507:3 at PaginationOptsGroup (https://localhost:8500/dist/main.349b81394543d8eb7e98.hot-update.js:32:22)

The solution: Change inline: true into inline: 'true'

imballinst commented 2 years ago

Hello, thanks for noticing this error! Could you describe the use-case that you want to implement and the source code? Thanks again!

This library is still using react-bootstrap@1.0.0-beta.5 (which is Bootstrap 4 API), which can be seen here: https://react-bootstrap-v4.netlify.app/components/forms/#form-props. As shown in the API page, inline is a boolean prop.

ahmetunal commented 2 years ago

Hi, we are trying to use this with "bootstrap": "5.1.1" and "react-bootstrap": "^2.0.0-beta.6", maybe that's why the storybook didn't have this error while we get. So far we didn't get any other problem. Any suggestions?

imballinst commented 2 years ago

hmmm, yes, I can see that's an issue because React Bootstrap 2 has a completely different API than React Bootstrap 1 (because the former uses Bootstrap 5 whereas the former uses Bootstrap 4).

I think we need to update the whole library if we want to make it compatible with Bootstrap 5. Let me see what I can do near this weekend. I'll log an issue. So the tasks list would be somewhat close to:

  1. Lock all dependencies for the better
  2. Update react-bootstrap to v2
  3. Update the parts of the codebase that imports react-bootstrap and adjust accordingly to the new API
imballinst commented 2 years ago

I logged the issue here: https://github.com/imballinst/react-bs-datatable/issues/100

ahmetunal commented 2 years ago

Thank you, that would be great. Please let me know if I can help.

imballinst commented 2 years ago

Thank you, that would be great. Please let me know if I can help.

Thanks! I'll let you know. As of now, I'm reviewing your other PR. I really appreciate the contribution! :smile:

ahmetunal commented 2 years ago

Thanks for the quick replies and code review

imballinst commented 2 years ago

Sure! If you don't mind, can I close this PR for now? I'll work on the the version that's compatible with React Bootstrap v2.

ahmetunal commented 2 years ago

No problem. Thanks again.