imbforge / NGSpipe2go

a set of NGS pipelines
GNU General Public License v3.0
24 stars 10 forks source link

use function parameters and return values #36

Closed oliverdrechsel closed 5 years ago

oliverdrechsel commented 7 years ago

a) functions called in the Rmd file take what's there in the namespace. Would it be an option to call the functions explicitly with variables?

b) functions in DE.shinyhelpers.R do not return explicitly. Since roxygen has the @return tag, would it be useful that the functions explicitly return something. This might cause the plotting functions, e.g. plotMDS, to have a slightly different usage?

oliverdrechsel commented 7 years ago

a) could save memory, if not too much stuff is copied around as input parameters

b) especially in plotting functions either using i) ggplot or ii) base plotting usage would be the same, if no explicit return() is called that needs to be i) printed or ii) not