search

imbo / behat-api-extension

API extension for Behat, used to ease testing of JSON-based APIs
MIT License
107 stars 42 forks source link

Updated to use guzzle 7 #100

Closed ghola closed 3 years ago

ghola commented 3 years ago

This MR brings the library up to date to use guzzle 7. Since guzzle 7 introduces deprecations and BC breaks, it was not possible to maintain the library compatible with guzzle 6 as well.

Additionally, I needed to force symfony/polyfill-mbstring to use version 1.20.0 because newer versions throw errors during the psalm check on PHP < 7.4.

Is there a chance you can make a release out of this? Since it introduces BC breaks, maybe it would require version 3?

christeredvartsen commented 3 years ago

I have been thinking of bumping the minimum requirement on PHP to 7.4 anyways before releasing v3 of this package, so I guess we can bump other deps as well.

I will do some other work on the develop branch before I merge this one, so you might have to rebase in a day or two, hope that is OK.

ghola commented 3 years ago

Sure, just let me know. Thank you!

On Wed, Apr 28, 2021 at 11:23 PM Christer Edvartsen < @.***> wrote:

I have been thinking of bumping the minimum requirement on PHP to 7.4 anyways before releasing v3 of this package, so I guess we can bump other deps as well.

I will do some other work on the develop branch before I merge this one, so you might have to rebase in a day or two, hope that is OK.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/imbo/behat-api-extension/pull/100#issuecomment-828752660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHDS3KELHVDRH55L6XKRYDTLBVC5ANCNFSM43U4BILQ .

christeredvartsen commented 3 years ago

Superseded by #102