search

imbo / behat-api-extension

API extension for Behat, used to ease testing of JSON-based APIs
MIT License
107 stars 42 forks source link

fix return type of jsonDecode method #117

Open garak opened 2 years ago

garak commented 2 years ago

Fix #116

christeredvartsen commented 2 years ago

For some reason the workflows won't trigger. Your change is not sufficient as the static analysis check will fail.

For the pull request to be approved and merged you must also provide some tests for the new behaviour. So if you could add some tests for non-array input that would be great.

christeredvartsen commented 2 years ago

I'm still not getting the option from GitHub to approve that you can run the workflow. Let me just try to closes the PR, then re-open it to see if that works.

garak commented 2 years ago

I see your github actions config has on: push. Maybe it should be on: [push, pull_request]?

christeredvartsen commented 2 years ago

🤦

Thanks for the obvious fix. :)