imbo / behat-api-extension

API extension for Behat, used to ease testing of JSON-based APIs
MIT License
109 stars 42 forks source link

New major version: 2.0 #39

Closed christeredvartsen closed 7 years ago

christeredvartsen commented 7 years ago

This pull request can be used to discuss the upcoming new major release of the extension.

Some stuff that needs to be done before an eventual merge:

rflipo-dev commented 7 years ago

👍 Thanks for those updates Could you set functions & attributes of ApiContext from private to protected ? Also Guzzle will still throw an error if we expect a 403 (in sendRequest() )

christeredvartsen commented 7 years ago

@rflipo-dev Could you have a look at the scenario I added in af03bc44756245d1036a6308aa0844197037cbe6 that tests a response with 403 Forbidden? That seems to be passing as expected. If I misunderstood the issue you are experiencing, could you open an issue and provide a test case that fails?

private methods have been changed to protected in ccfc1f9facd7d5b9ef54752aba1eb14e3d83e273.