search

imbo / imbo-metadata-search

Imbo plugin that enables metadata search
MIT License
3 stars 4 forks source link

Integration tests #6

Closed kbrabrand closed 9 years ago

kbrabrand commented 9 years ago

Switched to using the Imboclient instead of guzzle directly, and rewrote most of the feature file as a consequence of this. The suite now passes most of the tests, and the failing ones are caused by a few pieces of the ES backend implementation still missing.

Large parts of the context files has been copied from the Behat suite in the Imbo project. Need to figure out how to give proper attribution..

fangel commented 9 years ago

I think it looks great! What's the reason for disabling the Behat tests on Travis?

kbrabrand commented 9 years ago

The behat test execution failed with 500 internal errors from the PHP server. Will look into it in order to get them to run.

kbrabrand commented 9 years ago

But I won't spend the time right now, so I guess merging without behat is ok for now as long as the rest is ok..

fangel commented 9 years ago

Works for me. I'll merge it now then.

kbrabrand commented 9 years ago

Could you log on IRC, @fangel? I have an issue that I would like your input on if you have a few minutes..