search

imbrianj / switchBoard

Control of Internet connected devices within a given network via web interface.
MIT License
201 stars 53 forks source link

Connection stays open... #22

Closed jfeiler87 closed 9 years ago

jfeiler87 commented 9 years ago

and doesn't break when sending multiple commands. Also added 'Zone* Status' commands.

imbrianj commented 9 years ago

There's a parse error here: https://github.com/imbrianj/switchBoard/pull/22/files#diff-470f4125bce30a26d286bc93f9ce7ca0R114 where the last variable declared is followed by a comma instead of a semicolon. If you're able to fix and push, I can accept. Otherwise, I'll manually merge it this evening.

Thanks!

jfeiler87 commented 9 years ago

fixed :)

2014-08-25 20:30 GMT+02:00 Brian notifications@github.com:

There's a parse error here: https://github.com/imbrianj/switchBoard/pull/22/files#diff-470f4125bce30a26d286bc93f9ce7ca0R114 where the last variable declared is followed by a comma instead of a semicolon. If you're able to fix and push, I can accept. Otherwise, I'll manually merge it this evening.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/imbrianj/switchBoard/pull/22#issuecomment-53307014.

jfeiler87 commented 9 years ago

I have been trying to recreate the denon behaviour with a dummy python script that replys like the denon but failed so far. Replys work fine but they don't multiply in switchBoard like the denon ones do.

The denon is a really strange device ... telnet wise.

2014-08-25 20:32 GMT+02:00 Julian Pfosten asa23b@googlemail.com:

fixed :)

2014-08-25 20:30 GMT+02:00 Brian notifications@github.com:

There's a parse error here:

https://github.com/imbrianj/switchBoard/pull/22/files#diff-470f4125bce30a26d286bc93f9ce7ca0R114 where the last variable declared is followed by a comma instead of a semicolon. If you're able to fix and push, I can accept. Otherwise, I'll manually merge it this evening.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/imbrianj/switchBoard/pull/22#issuecomment-53307014.

imbrianj commented 9 years ago

On my "todo list" is to build out a node faux-device to reply with expected values for any given device, allowing full smoke testing. It's a ways out since it'd be a bit of an undertaking.

Awaiting the Travis build before closing this out.