imbrianj / switchBoard

Control of Internet connected devices within a given network via web interface.
MIT License
201 stars 53 forks source link

Nest Config not obvious #43

Closed rtkshmclane closed 9 years ago

rtkshmclane commented 9 years ago

Brian,

I cannot figure out what to put in my nest config section, beyond user and pass. I get this error:

/usr/local/src/switchBoard/controllers/nest.js:133 id = id.replace('00000000-0000-0000-0000-0001000000', ''); ^ TypeError: Cannot call method 'replace' of undefined at Object.module.exports.findLabel (/usr/local/src/switchBoard/controllers/nest.js:133:15) at Object.config.callback (/usr/local/src/switchBoard/controllers/nest.js:287:80) at IncomingMessage. (/usr/local/src/switchBoard/controllers/nest.js:537:22) at IncomingMessage.g (events.js:180:16) at IncomingMessage.EventEmitter.emit (events.js:117:20) at _stream_readable.js:920:16 at process._tickCallback (node.js:415:13)

This is on the first load, as nest is my default screen.

Second, I have a Yamaha IP connected receiver if you are interested in working on that as well. I will take a look at the developer section but I am not sure I know enough to code.

-sam

imbrianj commented 9 years ago

Username and password should be the only required inputs for nest. It looks like unexpected data is being returned from the api. What nest devices do you have - and how many? Tested with my setup which has one thermostat and four smoke detectors.

imbrianj commented 9 years ago

This commit may fix it. As I have both device types, it's difficult for me to test. I suspect that you see this error if you have only a smoke detector or only a thermostat - yet the device type you do not have is being partially populated. I added some checks to see if a serial number is associated before we try storing any device type from the API. https://github.com/imbrianj/switchBoard/commit/3e690531df14a6a8d92e0762936725f3c4962cae

imbrianj commented 9 years ago

Leaving this open for @rtkshmclane to offer feedback. I think it's fixed, but unable to reproduce (which isn't a surprise since I'm not sure what the API returns in all circumstances.

imbrianj commented 9 years ago

I believe this should fix that issue, but will need someone to test. https://github.com/imbrianj/switchBoard/commit/3e690531df14a6a8d92e0762936725f3c4962cae

Cleaning up bug queue. #ocd