search

imbushuo / mac-precision-touchpad

Windows Precision Touchpad Driver Implementation for Apple MacBook / Magic Trackpad
Other
9.11k stars 568 forks source link

Device ID, MacBook Pro 15 inch, Mid 2015, with retina screen #131

Closed chemPolonium closed 5 years ago

chemPolonium commented 6 years ago
image
cycorey commented 6 years ago

yes, my mac(MacBook Pro 15 inch, Mid 2015, with retina screen), Device ID is the same.

I installed the usb version, but not see any thing more in the control panel.

If @imbushuo could merge the support for MacBook Pro (15-inch, 2015), It will be a great help to me!

Terry2001 commented 5 years ago

my mac is same. hope for support, thanks very very much~~~

imbushuo commented 5 years ago

We actually have a few code for Mid 2015 device merged in. I don’t have the device (the original device owner has transferred the device to someone else), so it may be tricky for me to test it at this moment.

Plus I am dealing with intensive academic workload. If there is any update (likely summer), I will let you know.

From: Terry notifications@github.com Reply-To: imbushuo/mac-precision-touchpad reply@reply.github.com Date: Sunday, April 14, 2019 at 1:50 AM To: imbushuo/mac-precision-touchpad mac-precision-touchpad@noreply.github.com Cc: Bingxing Wang i@imbushuo.net, Mention mention@noreply.github.com Subject: Re: [imbushuo/mac-precision-touchpad] Device ID, MacBook Pro 15 inch, Mid 2015, with retina screen (#131)

my mac is same. hope for support, thanks very very much~~~

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/imbushuo/mac-precision-touchpad/issues/131#issuecomment-482921980, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF_kQUamCu9BHxetFT9yVbXu4E8UCTfxks5vgsGEgaJpZM4XAyNP.

Terry2001 commented 5 years ago

Thanks for reply soon. Maybe I can research how to test the driver on my device. I will try it in a few days. Could you tell me where I can find the document about setting a testing or development environment?

imbushuo commented 5 years ago

Here should have everything you need: https://docs.microsoft.com/en-us/windows-hardware/drivers/

By the way, there is no need for enabling test signing on UMDF drivers (in your case). And you don’t need to set up test agent (that’s for automation test).

For some reason, user-mode debugger never works for this driver, so most time I used WPP tracing and TraceView to help me diagnosing issues: https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/traceview

From: Terry notifications@github.com Reply-To: imbushuo/mac-precision-touchpad reply@reply.github.com Date: Sunday, April 14, 2019 at 2:00 AM To: imbushuo/mac-precision-touchpad mac-precision-touchpad@noreply.github.com Cc: Bingxing Wang i@imbushuo.net, Mention mention@noreply.github.com Subject: Re: [imbushuo/mac-precision-touchpad] Device ID, MacBook Pro 15 inch, Mid 2015, with retina screen (#131)

Thanks for reply soon. Maybe I can research how to test the driver on my device. I will try it in a few days. Could you tell me where I can find the document about setting a testing or development environment?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/imbushuo/mac-precision-touchpad/issues/131#issuecomment-482922461, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF_kQXj7tgwIE0fwfmlwxJS-M57BxCr2ks5vgsQQgaJpZM4XAyNP.

Terry2001 commented 5 years ago

@imbushuo Thanks for your great help. After modify some code, the touchpad is already working well in debug version. But I‘m not sure the code change is correct. I will debug it more.

commit link as below, could you review it if you have time. https://github.com/Terry2001/mac-precision-touchpad/commit/7a941b5daee3ad53feb2a1b890402b200548187b?diff=split

imbushuo commented 5 years ago

Hi,

This looks good to me. Could you kindly send me a PR?

Thanks, Bingxing Wang

Sent from my iPhone

On Apr 14, 2019, at 12:20 PM, Terry notifications@github.com<mailto:notifications@github.com> wrote:

@imbushuohttps://github.com/imbushuo Thanks for your great help. After modify some code, the touchpad is already working well in debug version. But I‘m not sure the code change is correct. I will debug it more.

commit link as below, could you review it if you have time. Terry2001@7a941b5?diff=splithttps://github.com/Terry2001/mac-precision-touchpad/commit/7a941b5daee3ad53feb2a1b890402b200548187b?diff=split

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/imbushuo/mac-precision-touchpad/issues/131#issuecomment-483009550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF_kQT1gpg-eKWJ1OwSUO19asKuU_sBwks5vg1VIgaJpZM4XAyNP.

Terry2001 commented 5 years ago

Let me test it a week and check some documents to confirm the modification is right. Then I will send a PR.

imbushuo commented 5 years ago

Merged through https://github.com/imbushuo/mac-precision-touchpad/pull/179.